> Adding alt-ctrl-LEFT/RIGHT (option-command-LEFT/RIGHT) key bindings to
> 
> - ListView
> - TreeView
> - TableView
> - TreeTableView
> 
> to support keyboard-only horizontal scrolling.  The main reason for the 
> change is to improve accessibility.
> 
> As far as I can tell, these key combinations do not interfere with editing.
> 
> The proposed solution can be further optimized by adding a public method to 
> the VirtualFlow class, something like
> 
> 
> public void horizontalUnitScroll(boolean right);
> 
> 
> Q: Does this change require a CSR to explain the change in the controls' 
> behavior?  We don't yet have the key bindings documented in 
> /doc-files/behavior
> 
> Note:
> Jenkins headful test passed on all mac configurations, failed on all linux 
> configurations (master branch failed also, so it is test issue), while 
> windows configuration is not yet available.

Andy Goryachev has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains eight additional 
commits since the last revision:

 - list view behavior
 - orientation
 - Merge remote-tracking branch 'origin/master' into 8313138.horizontal
 - Merge branch 'master' into 8313138.horizontal
 - Merge remote-tracking branch 'origin/master' into 8313138.horizontal
 - leaks
 - option command / alt ctrl
 - 8313138: TreeView/ListView Horizontal Scrollbar Keyboard enhancement

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1393/files
  - new: https://git.openjdk.org/jfx/pull/1393/files/80e70644..b306d8cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1393&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1393&range=00-01

  Stats: 11662 lines in 233 files changed: 6987 ins; 3447 del; 1228 mod
  Patch: https://git.openjdk.org/jfx/pull/1393.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1393/head:pull/1393

PR: https://git.openjdk.org/jfx/pull/1393

Reply via email to