On Thu, 29 Feb 2024 05:38:04 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Tested with the MonkeyTester, using different justification (left, right, >> center, justify) and node orientation, for both Text and TextFlow. Multiple >> Text instances, rich text, inline nodes, bidi, various line breaking >> scenarios. >> >> I could not find any issues! The new code also looks much cleaner and much, >> much easier to understand. I left a few non-essential suggestions inline. >> >> Overall, thank you @karthikpandelu and @hjohn. Good job guys! >> >> P.S. Tested on on macOS 14.3.1. The results on Windows/Linux should be >> identical, but if we can get some testing done on these two platforms that >> would be nice. > >> P.S. Tested on on macOS 14.3.1. The results on Windows/Linux should be >> identical, but if we can get some testing done on these two platforms that >> would be nice. > > I tested the changes in windows and do not see any issues. > I have executed the headful test using our headful test machines, no failures > found in all platforms. > > Addressed inline comments. Please check. I would like to thank @karthikpandelu and @hjohn - this PR was a major effort and you guys finally solved the major issue in javafx RTL text. 👏🏻 ------------- PR Comment: https://git.openjdk.org/jfx/pull/1323#issuecomment-1979047718
