On Mon, 26 Feb 2024 15:10:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add additional test for IOOBE detection. >> This test comes from JDK-8323787 > > Getting back to this.... I ran the test on macOS and it now works as > expected. However, one of the new tests fails on Linux: > > > SystemMenuBarTest > testFocusMemoryLeak FAILED > org.opentest4j.AssertionFailedError: expected: <false> but was: <true> > at > app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) > at > app//org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40) > at > app//org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:35) > at > app//org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:227) > at > app//test.com.sun.javafx.tk.quantum.SystemMenuBarTest.testFocusMemoryLeak(SystemMenuBarTest.java:198) > > > Btw, all of my tests were done in a local branch with the latest upstream > master merged in. > > @johanvos since the source branch is now a bit out of date, can you merge in > the latest upstream master? > > Also, I think there are still some unaddressed questions from John and Andy. > > Regarding the following: > >> All tests now pass, but I noticed that in some cases, the systemtests do not >> correctly work with the application lifecycle management (see >> https://mail.openjdk.org/pipermail/openjfx-dev/2024-January/044516.html). >> For now, I consider this anomaly to be independent from JDK-8319779 > > Yes, this is unrelated to the memory leak being fixed by this PR. We should > file a bug for the activation problem. @kevinrushforth thanks for the feedback. I merged master and I see the failing test on Linux now as well. That is very interesting. I'll investigate and fix, and address the other comments as well. Also, I got some offline feedback about edge cases that I'm still trying to reproduce. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1283#issuecomment-1966126023
