On Fri, 23 Feb 2024 18:31:10 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs
>> in `Node` and `Scene`.
>>
>> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
>> system property, while for `Node` it isn't (which means `SubScene` will be
>> different from `Scene`). Not sure if this is intended.
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java
> line 187:
>
>> 185: * Returns the child's bottom anchor constraint, if set.
>> 186: * @param child the child node of an anchor pane
>> 187: * @return the offset from the bottom of the anchor pane, or {@code
>> null} if no bottom anchor was set
>
> minor suggestion: move explanation of when it returns null to the
> description, i.e.:
>
>
> Returns the child's bottom anchor constraint, if set, otherwise returns
> {@code null}.
>
> @return the offset from the bottom of the anchor pane, or {@code null}
I don't mind either way.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1379#discussion_r1501096059
