On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger <rlich...@openjdk.org> 
wrote:

> The PR simply moves column and view-updates outside the loop. Since the 
> column or view never changes within the for-loop it is not necessary to call 
> these again and again.

Looks good to me.

Checking `updateTableColumn` and  `updateTableView`, I can see that those 
operation will clean up and register a lot of properties and listener, so it is 
a good thing to do that just once (since we never change the column or table 
inbetween).

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1358#pullrequestreview-1867503900

Reply via email to