On Thu, 1 Feb 2024 09:20:35 GMT, Karthik P K <k...@openjdk.org> wrote:

>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation 
>> conditions were not considered, hence hit test values such as character 
>> index and insertion index values were incorrect.
>> 
>> Added checks for RTL orientation of nodes and  fixed the issue in 
>> `getHitInfo()` to calculate correct hit test values.
>> 
>> Added system tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Code review changes

Fixed the above issues. I have simplified the logic little bit so that it 
doesn't get confusing as I add more conditions.
I tested using the monkey tester and automated tests. Please let me know if you 
find issue in any scenario.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1323#issuecomment-1929218388

Reply via email to