On Sat, 27 Jan 2024 00:07:21 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

> The tests from [JDK-8159048](https://bugs.openjdk.org/browse/JDK-8159048) 
> should either be removed or reworked. @kevinrushforth Should I just check 
> that calling the specified methods both from the FX thread and from a 
> background thread end up executing on the FX thread?

Checking that the animation always runs on the FX thread seems useful. It might 
also be worth adding a test based on the original reproducer in 
[JDK-8159048](https://bugs.openjdk.org/browse/JDK-8159048).
 
> Running `./gradlew :systemTests:test --tests 
> test.com.sun.javafx.animation.AnimationTest` still succeeds for me for some 
> reason even after a clean. Is there something missing here?

The system tests are only run if `-PFULL_TEST=true` is passed to gradle.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1352#issuecomment-1913173972

Reply via email to