On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly and no other JavaFX API accepts or returns a SimpleSelector or >> CompoundSelector. >> >> We should deprecate them for removal so we can move them to a non-exported >> package, removing them from the public API. > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Add since parameter to deprecation annotation > Should this change also introduce a public method > `Selector.getStyleClasses()` and/or `Selector.getStyleClassesSet()` due to > [#1333 > (comment)](https://github.com/openjdk/jfx/pull/1333#issuecomment-1900085510) ? Maybe yes, it depends on how important it is that SceneBuilder keeps working with newer and older FX releases 1. If SceneBuilder is tied to the same FX release, it just needs to be updated at the same time 2. If an older SceneBuilder must keep working with JavaFX 23, then we can't move those classes ever 3. If the requirement is only that it is compatible with one older version, then I guess we can introduce a new public method in 22. It would mean that the updated SceneBuilder would no longer work with JavaFX 21 or older versions. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1900712837
