On Wed, 10 Jan 2024 20:13:24 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Code review changes > > tests/system/src/test/java/test/robot/javafx/scene/RTLTextCharacterIndexTest.java > line 48: > >> 46: import javafx.stage.StageStyle; >> 47: import javafx.stage.Window; >> 48: import org.junit.After; > > should we be using junit5 for all new tests? Made changes in both the test files to use unit5 > is there a reason to cast to int? No, I reused an old test file and developed these tests based on that. Hence the cast was kept as it is. >fx robot does accept double arguments, and we might be dealing with fractional >scale on some platforms Removed the cast. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1448631575 PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1448631045
