On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin <d...@openjdk.org> wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables >> items were null. > > Carl Döbbelin has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8323543: clean up code I think it makes sense to add the checks in this PR. We are addressing the issue and not introducing new code paths. I wonder if we should also add the unit tests to cover the newly added checks. What do you think? modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 6081: > 6079: > 6080: assertDoesNotThrow(() -> Toolkit.getToolkit().firePulse()); > 6081: extra newline? modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 7276: > 7274: > 7275: assertDoesNotThrow(() -> Toolkit.getToolkit().firePulse()); > 7276: please remove extra newline ------------- PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1885514538 PR Review Comment: https://git.openjdk.org/jfx/pull/1329#discussion_r1447838560 PR Review Comment: https://git.openjdk.org/jfx/pull/1329#discussion_r1447808424
