On Tue, 26 Dec 2023 23:42:56 GMT, Martin Fox <m...@openjdk.org> wrote:
>> When reporting input method candidate position the code in >> GlassViewEventHandler is not applying the platform scale factors. This is >> causing incorrect IM positions to be reported to glass on hi-dpi monitors. >> >> This PR a no-op on Mac since the platform scale factors are always 1.0. I >> don't think it affects the current Linux XIM code at all but XIM is so >> out-of-date it has become difficult to test. PR #1080 will replace the old >> XIM code and needs this fix to work properly on hi-dpi screens. > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > IM coordinates are relative to main screen The fix looks correct to me. I'll test it on Windows as part of formally reviewing it. .idea/misc.xml line 1: > 1: <?xml version="1.0" encoding="UTF-8"?> The changes in this file should be reverted, since it isn't related to the bug being fixed. ------------- PR Review: https://git.openjdk.org/jfx/pull/1311#pullrequestreview-1801197698 PR Review Comment: https://git.openjdk.org/jfx/pull/1311#discussion_r1439937166
