On Sat, 9 Dec 2023 08:40:31 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> This PR enhances the documentation of `Platform.Preferences.accentColor`: >> >> >> /** >> - * The accent color. >> + * The accent color, which can be used to highlight the active or >> important part of a >> + * control and make it stand out from the rest of the user interface. It >> is usually a >> + * vivid color that contrasts with the foreground and background colors. >> >> >> Additional changes include alternating row colors for tables. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > wording, table styling Updated docs look good. I left a comment about the html `id` of the tables. modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 473: > 471: * <p> > 472: * The following preferences are potentially available on the > specified platforms: > 473: * <table id="preferences-table" class="striped"> I recommend changing the ID to `id="preferences-table-windows"` and adding `id="preferences-table-macos"` and `id="preferences-table-linux"` to the other two. ------------- PR Review: https://git.openjdk.org/jfx/pull/1301#pullrequestreview-1773720598 PR Review Comment: https://git.openjdk.org/jfx/pull/1301#discussion_r1421441742
