On Mon, 4 Dec 2023 22:05:53 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> check for pending exceptions in Windows PlatformSupport > > modules/javafx.graphics/src/main/native-glass/mac/GlassMacros.h line 165: > >> 163: >> 164: // assert there is no outstanding java exception pending, return >> otherwise >> 165: #define GLASS_CHECK_EXCEPTIONALLY_RETURN(ENV) >> \ > > Minor: `GLASS_CHECK_EXCEPTION_RETURN` might be a more consistent name (but > please leave it as is if you prefer). I changed the name of this macro, as well as that of `GLASS_CHECK_NONNULL_EXCEPTIONALLY_RETURN`. > modules/javafx.graphics/src/main/native-glass/win/PlatformSupport.cpp line > 235: > >> 233: jobject prefValue = value ? >> 234: env->GetStaticObjectField(javaClasses.Boolean, >> javaIDs.Boolean.trueID) : >> 235: env->GetStaticObjectField(javaClasses.Boolean, >> javaIDs.Boolean.falseID); > > Minor: do you think it is worth caching `Boolean.TRUE` and `Boolean.FALSE` in > static `const` variables? It likely won't matter much. I don't think it matters one way or the other. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1416483975 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1416484821
