On Tue, 28 Nov 2023 00:26:32 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Provides a public utility method for use by the skins (core and custom) to >> simplify initialization of styleable properties. >> >> >> + /** >> + * Utility method which combines CssMetaData items in one unmodifiable list >> with the size equal to the number >> + * of items it holds (i.e. with no unnecessary overhead). >> + * >> + * @param list the css metadata items, usually from the parent, not nullable >> + * @param items the additional items >> + * @return the unmodifiable list containing all of the items >> + * >> + * @since 22 >> + */ >> + public static List<CssMetaData<? extends Styleable, ?>> initStyleables( >> + List<CssMetaData<? extends Styleable, ?>> list, >> + CssMetaData<? extends Styleable, ?>... items) > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 341: > 339: * @since 22 > 340: */ > 341: public static List<CssMetaData<? extends Styleable, ?>> > initStyleables( Have you considered a method name such as `concat` or `combine`? This method doesn't initialize styleable properties (nor their metadata). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1296#discussion_r1406937535
