On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). > > Will wait for the changes to be approved here, then I'll file the CSR. > > Saves upkeeping 2 copies. > > this should be a standard operating procedure, in my opinion. For simple CSRs, yes. For more complicated changes, there is value in getting CSR feedback in parallel, although even in that case it's usually best to wait until the review of the API changes are far enough along that big changes aren't expected. The changes look like what I would expect. I'll take a closer look at the PR and CSR soon. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1294#issuecomment-1828847436 PR Comment: https://git.openjdk.org/jfx/pull/1294#issuecomment-1828847486
