On Fri, 17 Nov 2023 19:20:32 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename Appearance to ColorScheme
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
> 578:
>
>> 576: * from the perceptual brightness of {@link
>> #backgroundColorProperty() backgroundColor} in relation
>> 577: * to {@link #foregroundColorProperty() foregroundColor} and
>> defaults to {@link ColorScheme#LIGHT}
>> 578: * if the platform does not report color preferences.
>
> Do we want to allow for the possibility of a platform reporting the color
> scheme directly (rather than specifying that it is always derived from the
> relative brightness of the foreground and background colors)? I can't think
> of a need off hand.
I've removed the language that specified how the color scheme is determined, as
it is immaterial for read-only platform preferences. This question will become
relevant for mutable application preferences, where we will need to decide
whether `colorScheme` is automatically derived from foreground and background
colors, or whether it will need to be set by application developers _along
with_ the foreground and background colors.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1397995715
