On Thu, 9 Nov 2023 13:06:50 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> The test changes look good. One thing I noticed is that it now takes ~ 50 > seconds to time out if there is a failure (a call to checkCollectable that > returns false takes ~ 1 second, which is needed to ensure that it is a robust > check). > > Maybe cut down the number of menu objects from 50 to, say, 10? I'll approve > it as is, since the only way this will ever be a problem is if we reintroduce > this bug, and it's still under 1 minute so OK. makes sense, done. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1277#issuecomment-1804061283
