On Thu, 2 Nov 2023 11:39:47 GMT, Johan Vos <j...@openjdk.org> wrote: > When the Java layer removes a systemmenu, release the native resources > related to this systemmenu. > This removes the strong JNI Global ref, which prevents its references from > being gc'ed. > > The current implementation for the mac-specific system menu creates a menu, > but never releases its resources. In the `dealloc` of this menu, the strong > jni refs are deleted. > With this PR, we now release the native resources associated with a menuItem > when that one is removed from a menu. A consequence is that this menuItem > should never be used after being removed from its current menu (e.g. it > should not be re-added, or its text/shortcut should not be altered). > The current implementation will create a new MacMenuDelegate every time a > menuItem is inserted into a menu, so there should be no references to the > native resources lingering.
Is it possible to add an automated regression test? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1277#issuecomment-1790622466
