On Thu, 12 Oct 2023 09:40:18 GMT, Karthik P K <k...@openjdk.org> wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when hitTest was invoked for >> Text node in a TextFlow with more than one Text child. Hence wrong character >> index value was calculated. >> >> Since only x, y coordinates were available in the above mentioned method, >> sending the text as a parameter to this method is necessary so as to know if >> the text run selected for character index calculation is correct. Along with >> this change modified the `PrismTextLayout::getHitInfo()` method to calculate >> the correct character index. >> >> Added tests to validate the changes. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Fix repeating text node issue Made changes in code as suggested above. > Another observation, and it may be a different issue. If i try to insert a > Text instance with -fx-scale-x:200% into the flow, the scale affects the > glyph rendering but neither caretShape, preferredWidth, nor hitInfo: This looks like a different issue. I will raise a new bug if it is not reported already. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1157#issuecomment-1761005682
