On Fri, 22 Sep 2023 09:43:52 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Fixes the regression by basically reverting one change introduced in >> https://bugs.openjdk.org/browse/JDK-8311983. >> The problem is that it is actually required to get the size from a cell with >> the index -1, which technically does not exist (the accumCell is used then). >> >> Furthermore, unlike the name suggests, the call to `addLeadingCells()` is >> always needed, even if there are none. >> This is because the method does much more than what you would think first. >> >> In future, it would probably be good to revisit this code. Also performance >> wise, since this looks like something that can be optimized. But that is >> another story, not related to this fix. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8316590: More tests The changes LGTM. It fixes the regression. ------------- Marked as reviewed by kpk (Committer). PR Review: https://git.openjdk.org/jfx/pull/1246#pullrequestreview-1659094698
