On Tue, 15 Aug 2023 17:26:11 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Unless we suspect a problem, I don't see a need to do anything differently. > > A possible problem is we might reach the maximum of open file handles in the > underlying OS (I've experienced this before). I think we should definitely > fix it (in a separate ticket). > > Curiously, the code example for Files.copy(InputStream in, Path target, > CopyOption... options) does not include closing of input stream, though it > has some verbiage about promptly closing the input stream in case of an > error. I think javadoc there might need to be improved. I've filed https://bugs.openjdk.org/browse/JDK-8314500 for closing the inputStream. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1188#discussion_r1296932348
