On Fri, 4 Aug 2023 22:12:55 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for > the sake of testing. > It is only changed by some JUnit tests to remove the need of setting up the > whole table framework. > This PR shifts this flag from those two classes to the shim classes, which > are not inside the final JavaFX product, only used for testing. Where possible, avoiding injection of test flags into production code is better, so this seems like a reasonable cleanup. @aghaisas can you review this? It probably doesn't need a second reviewer, but you can decide. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1198#issuecomment-1666509050
