On Fri, 21 Jul 2023 21:19:09 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Check FXEnabled initially
>
> tests/system/src/test/java/test/javafx/embed/swing/JFXPanelNPETest.java line
> 98:
>
>> 96: });
>> 97: SwingUtilities.invokeAndWait(JFXPanelNPETest::createUI);
>> 98: for (int i = 0; i < 300; i++) {
>
> I think this is way too long for a unit test. 300 iterations, 200 ms each =
> 60 seconds
good point!
at the same time, we probably want to cover both extremes (short and long
delays).
what would be a reasonable upper limit for a test? 10 seconds?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1178#discussion_r1271123737
