On Wed, 14 Jun 2023 19:35:19 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move Subscription method for invalidations to Observable >> >> - moved Subscription class to the Observable package > > I reviewed the proposal in the JBS enhancement and the proposed API in this > PR. I think this would be a useful addition to JavaFX. I left a few questions > and comments. > @kevinrushforth I changed the docs a bit, if there's agreement on the new > changes I can still update the CSR I hope. Otherwise, as it doesn't change > semantics, I suppose this could be done separately as well. The doc changes, including the change to the argument names, looks good to me. Go ahead and update the CSR accordingly, and I'll "Review" it. Any other clarifying doc changes can be done subsequent to this. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1069#issuecomment-1631577149
