On Sun, 9 Jul 2023 17:43:05 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

> The bug happens because `gdk_window_get_frame_extents` is not returning the 
> correct position when o i3-wm, probably by some bug on the wm itself.
> 
> Te fix replaces the usage of the function for already known extents value 
> calculation.

modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1016:

> 1014:     if (frame_type == TITLED) {
> 1015:         GdkRectangle rect;
> 1016:         gdk_window_get_frame_extents(gdk_window, &rect);

Looking at potential regression: in case of a TITLED frame, before this patch 
you would use `get_frame_extents` and now you will use `get_origin` in all 
cases. Are there scenario's where this might lead to regression, or is there a 
way to test this?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1173#discussion_r1257878275

Reply via email to