On Thu, 15 Jun 2023 12:16:20 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> I replicated the fix on #1054 on Linux. >> >> Also fixes [Monocle: Stage no longer gets focus after fix for >> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Review changes Copyright year changes are incorrect. modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/MouseEventFirerTest.java line 2: > 1: /* > 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. No, we never remove the start year in a copyright line. this should be: `2020, 2023,` Alternatively, you can just revert this change, since we will run a script to update them all. Either is fine. modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 2: > 1: /* > 2: * Copyright (c) 2011, 2023, Oracle and/or its affiliates. All rights > reserved. `2022, 2023,` ------------- Changes requested by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1110#pullrequestreview-1481491145 PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1230961089 PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1230961274
