On Fri, 28 Apr 2023 01:24:51 GMT, John Neffenger <jgn...@openjdk.org> wrote:
>> I solved the build failure occurring on Windows by downgrading to Visual >> Studio 2022 [Build Tools version 17.1.0][1], dated February 15, 2022, from >> the prior version 17.5.4 that I was using. I opened a bug report, linked >> below, as a *heads-up* for when we upgrade Visual Studio. >> >> I'm now using the following versions of the tools: >> >> #### Toolchains >> >> * **Linux:** gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0 >> * **macOS:** Command Line Tools for Xcode 14.2 version 14.2.0.0.1.1668646533 >> * **Windows:** Visual Studio Build Tools 2022 version 17.1.0, build number >> 17.1.32210.238 >> >> #### Build Tools >> >> * **JDK:** OpenJDK Runtime Environment (build 19.0.2+7-44) >> * **Ant:** Apache Ant(TM) version 1.10.13 compiled on January 4 2023 >> * **CMake:** cmake version 3.26.3 >> >> My latest test results are: >> >> | System | Develop | Actions | Release | Notes | >> |:-------:|:-------:|:-------:|:-------:| ------------------------- | >> | Linux | ✔ | ✔ | ❌ | `libjfxwebkit.so` differs | >> | macOS | ✔ | ✔ | ✔ | Just luck, I suspect. | >> | Windows | ✔ | ✔ | ❌ | `jfxwebkit.dll` differs | >> >> where: >> >> * ✔ means that all of the files in the `build` directory were identical >> between the two consecutive builds, and the unit tests ran successfully, >> while >> * ❌ means that there were differences in the native libraries between the >> two builds. >> >> I created bug reports to track each of the remaining potential problems: >> >> * [JDK-8306884][2]: Building WebKit on Linux is not deterministic >> * [JDK-8306885][3]: Building WebKit on Windows is not deterministic >> * [JDK-8306886][4]: Building macOS libraries can be non-deterministic >> * [JDK-8306887][5]: Error C2327 while compiling WebKit on Windows >> >> [1]: >> https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history#fixed-version-bootstrappers >> [2]: https://bugs.openjdk.org/browse/JDK-8306884 >> [3]: https://bugs.openjdk.org/browse/JDK-8306885 >> [4]: https://bugs.openjdk.org/browse/JDK-8306886 >> [5]: https://bugs.openjdk.org/browse/JDK-8306887 > >> I created bug reports to track each of the remaining potential problems: > > I forgot the original remaining problem! It's listed as item 4 under > **Fixes** in the description at the top of this pull request and now > described by the following bug report: > > * [JDK-8307082](https://bugs.openjdk.org/browse/JDK-8307082): Build path is > recorded in JavaFX Controls module > @jgneff Can you merge in the latest master? This will pick up the recent > compiler updates along with any other recent changes. Thank you, Kevin, for your patience while I was away on vacation. I'll also give this another test, at least on Linux, as my own final review. ------------- PR Comment: https://git.openjdk.org/jfx/pull/446#issuecomment-1589689383