On Tue, 13 Jun 2023 13:52:46 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
> Fixing JDK-8309935 and providing a test for it. The fix and the test look OK to me. Have you tested it on all platforms (including Linux and Windows, which will ignore the attempt to use a system menu bar, but should otherwise behave as expected)? I left a couple inline comments. tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 1: > 1: package test.javafx.stage; This needs a standard copyright header. tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 7: > 5: import org.junit.Test; > 6: import test.util.Util; > 7: import test.util.memory.JMemoryBuddy; Unused import. ------------- PR Review: https://git.openjdk.org/jfx/pull/1152#pullrequestreview-1477388941 PR Review Comment: https://git.openjdk.org/jfx/pull/1152#discussion_r1228268233 PR Review Comment: https://git.openjdk.org/jfx/pull/1152#discussion_r1228282730
