> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. > > Here's whats happening: > > We include all event masks, so when using gtk3 (>= 3.4.0) it includes > `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with > `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction > (UP/DOWN). > > When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored > it causing it to send deltas (x,y) = 0. > > The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also > adding smooth scroll functionality.
Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 42 additional commits since the last revision: - Merge branch 'master' into fix_scrolling - Listen only to smooth deltas - Merge branch 'master' into fix_scrolling - Remove print statement - Merge branch 'master' into fix_scrolling - Improve direction - Rename var - Fix direction - Fix for Ubuntu 20.04 - Fix scroll event - ... and 32 more: https://git.openjdk.org/jfx/compare/7a9c1b40...59a33014 ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1044/files - new: https://git.openjdk.org/jfx/pull/1044/files/176f5a50..59a33014 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=09 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=08-09 Stats: 41111 lines in 875 files changed: 13073 ins; 3563 del; 24475 mod Patch: https://git.openjdk.org/jfx/pull/1044.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1044/head:pull/1044 PR: https://git.openjdk.org/jfx/pull/1044
