On Wed, 31 May 2023 22:36:54 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> - Added missing exception checks for JNI calls. >> - Improved JNI error checking by checking for both exception and return >> value. >> - Minor code clean up. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8304290: Some JNI calls made without checking exceptions in media [v2] I identified two potential issues (see below). The rest looks good. modules/javafx.media/src/main/native/jfxmedia/jni/JavaPlayerEventDispatcher.cpp line 199: > 197: } > 198: > 199: pEnv->DeleteLocalRef(jmessage); This needs to be moved inside the previous `if` block. modules/javafx.media/src/main/native/jfxmedia/jni/JniUtils.cpp line 59: > 57: } > 58: // This shouldn't happen... > 59: return; Don't you still need this `return`? ------------- PR Review: https://git.openjdk.org/jfx/pull/1094#pullrequestreview-1463420165 PR Review Comment: https://git.openjdk.org/jfx/pull/1094#discussion_r1218582474 PR Review Comment: https://git.openjdk.org/jfx/pull/1094#discussion_r1218591790
