On Fri, 12 May 2023 14:45:43 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Carl Döbbelin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> made launcherimpl one line
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Platform.java line 67:
>
>> 65: }
>> 66:
>> 67: if (PlatformUtil.isMac()) {
>
> this change might be ok, but it is not strictly equivalent.
> before, MAC path would be selected if os.name lowercase starts from either
> "mac" or "darwin", after the change, only starts with "Mac".
> Do we want to support "darwin"?
I'd still prefer to use PlatformUtil, since this is a cleaner solution that the
variety of methods used before:
osNameLowerCase.startsWith("wind"
"ios".equals(System.getProperty("os.name")
osName.startsWith("Windows"
osName.startsWith("Mac OS"
("os.name").toLowerCase().indexOf("win")
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1132#discussion_r1192483282
