On Mon, 8 May 2023 16:46:54 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java >> line 357: >> >>> 355: * @since 21 >>> 356: */ >>> 357: TOGGLE_STATE(Integer.class), >> >> Would a dedicated enum be a better choice here? > > Yes, that might be cleaner. In any case, we should not hard-code or specify > int values that are Windows-specific. I recommend defining this as a > platform-independent attribute and then mapping it in the Windows platform > code. Added a new enum `ToggleState`. It is added as a member of `AccessibleAttribute` : Please see if it is a good place for the enum. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1088#discussion_r1192203187
