On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> Focused only on raw type problems, and removing casts that were no longer > needed because of the changes. Patch seems okay for me, I also run it on Windows and macOS and tests are all good. I left a minor comment about some leftover imports which could be cleared. modules/javafx.graphics/src/main/java/com/sun/prism/es2/GLFactory.java line 32: > 30: import java.security.AccessController; > 31: import java.security.PrivilegedAction; > 32: import java.util.HashMap; I think this import can be removed now. Also check derivatives (aka. other `GLFactory`-ies extending this one) ------------- PR Review: https://git.openjdk.org/jfx/pull/1095#pullrequestreview-1412765069 PR Review Comment: https://git.openjdk.org/jfx/pull/1095#discussion_r1184811230
