On Thu, 27 Apr 2023 11:58:02 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review comments > > gradle.properties.template line 82: > >> 80: # Recommended to use TEST_ONLY instead of this property. >> 81: >> 82: #BUILD_SDK_FOR_TEST = false > > Suggestion: Maybe remove this, since it is only kept for compatibility? It's > fine if you want to keep it. Removed `BUILD_SDK_FOR_TEST`. It seems safer and right to remove. It may be confusing to keep two flags for same action. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1117#discussion_r1182268657
