On Fri, 28 Apr 2023 23:40:55 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. Unlike Ensemble, the goal of this >> application is to facilitate manual testing rather than demonstrate the >> capabilities of JavaFX. >> >> Feedback and suggestions are always welcome. >> >>  > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments I am not convinced this belongs in the OpenJFX repository. I clearly see the value of tools like this, and I highly encourage developers to use those -- they are fantastic. However, for OpenJFX, I believe we should focus more on exact tests (which can be unit tests, for example). For many applications, it can be useful if a user shows a visual artifact and explains that to a developer. But for developers talking about issues with other developers, I believe we should try to stick as much as possible to numbers. We describe the expected behavior and the actual behavior which are both, in the end, represented by numbers. I won't oppose this PR, but I am worried that this will not increase the number of regression tests. The regression tests we currently have are incredibly valuable, and they saved us from lots of regression. But I believe we need more regression tests. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1097#issuecomment-1528804084
