On Fri, 21 Apr 2023 13:18:31 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

> Adds the javadoc commands to generate the NEW page and to be able to select 
> versions in the DEPRECATED page.

Notes to reviewers:

1. The `-since` option does not play well with the javafx one: if documentation 
was added on a `private` property field with the `@since` tag, it will not be 
included in the NEW and DEPRECATED lists. I presume that the `-since` release 
version comparison detects only public APIs and does not know that javafx 
generates public API from private members.

    As an example, the attenuation properties in `PointLight` have `@since 16`, 
but do not appear in the NEW page.

2. I started from version 9, but there are also versions "8" and "8u20" in the 
deprecation list, and "JavaFX 8u40" and "JavaFX 8.0" in `@since` tags. For 
comparison, the JDK starts from 12 
(https://docs.oracle.com/en/java/javase/20/docs/api/new-list.html). I'm not 
sure what versions we want to include. Changing this is simply done by adding 
the strings that appear in the tags to the `-since` option list.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1109#issuecomment-1517839786

Reply via email to