On Wed, 19 Apr 2023 22:50:45 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> Skipping the test until > [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753) is implemented. The check for whether or not this is a fractional scale looks fine. However, you need to file a new JBS Bug and use that new bug to skip this test. Unless the test fundamentally cannot ever work with fractional scales (which I don't think is the case), skipping it on a system with a fractional scale is meant to be temporary until the bug (JDK-8305709) is fixed, rather than being a fix for that bug. You should list JDK-8305709 in a comment as the reason for skipping the test (see inline). tests/system/src/test/java/test/robot/javafx/scene/tableview/TableViewResizeColumnToFitContentTest.java line 98: > 96: (colTwoWidth != table.getColumns().get(1).getWidth())); > 97: > 98: if (!Util.isFractionalScale(table)) { Please add a comment with the bug ID of the bug that is the reason for skipping this part of the test. Something like: // Skip this check on platforms with fractional scale until JDK-8305709 is fixed ------------- Changes requested by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1102#pullrequestreview-1393810290 PR Review Comment: https://git.openjdk.org/jfx/pull/1102#discussion_r1172472088
