On Fri, 7 Apr 2023 22:40:32 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Make intellij see :systemTests dependecies" >> >> This reverts commit dca7eab24958e1214147b7d291f0faf52ea27ddf. >> - Make intellij see :systemTests dependecies > > .gitignore line 67: > >> 65: >> 66: #mac folder >> 67: .DS_Store > > These seem unrelated to this PR (and in the case of `hs_err`, there is a > typo). Removed them > checkstyle.xml line 1: > >> 1: <?xml version="1.0"?> > > I'm not keen on adding yet another top-level file in our repo. Can it go > somewhere else? I've looked for a place, but didn't found one that would make sense. It could be used on eclipse as well and probably on netbeans. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1009#discussion_r1167667502 PR Review Comment: https://git.openjdk.org/jfx/pull/1009#discussion_r1167667672
