On Sat, 18 Feb 2023 17:59:12 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> Most of the changes revolve around unifying the sorting methods for a > collection with `Comparable` elements with sorting methods that take an > external `Comparator` by passing `Comparator.naturalOrder()` from the former > to the latter. This eliminates method duplication and some warnings > suppressions. > > Note that I get 1 failing test: VersionInfoTest.testMajorVersion. This PR is > unrelated to this test. Looks good, no comments. There are some documentation changes in public API, is a csr needed? ------------- Marked as reviewed by jhendrikx (Committer). PR Review: https://git.openjdk.org/jfx/pull/1041#pullrequestreview-1374695119 PR Comment: https://git.openjdk.org/jfx/pull/1041#issuecomment-1498933647
