On Sun, 2 Apr 2023 23:50:15 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
>> some edge cases.
>>
>> 1. `removeAll(c)`:
>> This is a no-op if 'c' is empty.
>> For `ObservableListWrapper`, returning early skips an object allocation. For
>> `ObservableSetWrapper` and `ObservableMapWrapper`, returning early prevents
>> an enumeration of the entire collection.
>>
>> 2. `retainAll(c)`:
>> This is a no-op if the backing collection is empty, or equivalent to
>> `clear()` if `c` is empty.
>>
>> I've added some tests to verify the optimized behavior for each of the three
>> classes.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> addressed review comments
Looks good. If you choose to fix the new lines I'll re-approve.
I looked at the JDK code of these methods, it seems like it could also use
these optimizations.
-------------
Marked as reviewed by nlisker (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/751#pullrequestreview-1370588012
