On Thu, 15 Dec 2022 12:23:12 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> This includes a fix for the precision problem we've found as part of the >> graphics warnings clean ups. >> >> I've included two commits, one with just the minimal fix, and one with the >> clean ups. I can drop off the 2nd commit if it is deemed to be of no added >> value. > > John Hendrikx has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains five commits: > > - Merge remote-tracking branch 'upstream/master' into > feature/precision-problem-in-gesture-recognizers > - Make RotateGestureRecognizer easier to test > - Revert all changes to RotateGestureRecognizer > - General clean ups > > - Made constants written in capitals final > - Made fields final that can be final > - Made fields and methods private that can be private > - Renamed constants that aren't constant to camel case > - Fixed spelling errors > - Re-ordered fields (statics at the top) > - Removed redundant initial values > - Removed unused fields and parameters > - Optimized imports > - Removed commented out code > - Fix precision problems in gesture recognizers I think this change still has merit. I also think the change to make the code more testable is a good thing. A lot of code in JavaFX is hard to test, and when things are hard to test, the testing is often done poorly or not at all -- these classes did not have any tests. ------------- PR Comment: https://git.openjdk.org/jfx/pull/966#issuecomment-1492885820
