On Wed, 29 Mar 2023 21:01:30 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> > Thank you very much @hjohn for your extensive review. Before addressing > > your comments, I'd like to get some clarification (ideally also from > > @kevinrushforth), because I am a bit confused by the discussion so far. If we can resolve all of the concerns with the existing approach, without the need for a more holistic fix, then it seems OK to proceed with this. The question is: can we? > > This PR is a very narrow patch that fixes an obvious bug in `HBox` and > > `VBox`. It's narrow in that it doesn't change the present algorithm, it > > merely corrects some of its flaws. There is a little bit of refactoring, > > but that's only done where it helps readers to better understand the > > algorithm. > > Yes, I think it's an improvement in filling the boxes properly (I asked for > some clarification as I found the code hard to read, but that's probably how > you found it). My only worry is that it fixes this specific problem, but may > be introducing a new issue (I think snapping values multiple times can > introduce artifacts in the child sizes, even though they will all align > correctly, I think they might be off a bit). If you can confirm this isn't > the case, or if it is, fix those last problems then I think it is a positive > change. This was one my worries as well, but I haven't looked at it closely enough to point out any specific concerns. ------------- PR Comment: https://git.openjdk.org/jfx/pull/445#issuecomment-1491065670
