On Thu, 16 Mar 2023 06:09:03 GMT, Karthik P K <k...@openjdk.org> wrote:

>> When converter was changed, `setText` method of spinner was not invoked to 
>> update the spinner text using new converter.
>> 
>> Added a listener to converter property of `SpinnerValueFactory` to call 
>> `setText` so that spinner text is updated using new converter.
>> 
>> Added unit test to validate the fix. Along with spinner of Double type, 
>> added a spinner of Integer type as well so that the fix is validated using 2 
>> types of spinner.
>
> Karthik P K has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Address review comments

Looks good!

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/1057

Reply via email to