On Tue, 7 Mar 2023 20:18:59 GMT, Andy Goryachev <[email protected]> wrote:
>> This fixes an the AIOOBE when finding a line break point in RTL laid out
>> glyphs.
>> The comment in the bug report explains how we can end up trying to find an
>> unachievable break point and yet there's no "stop" on the search when we've
>> run out of glyphs so hence the exception.
>>
>> The fix uses a different method to choose a break point.
>>
>> A system test has been supplied which will fail on macOS (even with standard
>> macOS fonts, not just the Noto Sans Arabic) unless the fix is applied.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/TextRun.java line
> 288:
>
>> 286: */
>> 287: /* Not need to check for compact as bidi disables the
>> simple case */
>> 288: for (int gi = glyphCount; gi <= 0; gi--) {
>
> should we also correct the comment on line 288?
oops. I think I see the problem.
And I had noticed the typo in the existing comment and can correct that ..
-------------
PR: https://git.openjdk.org/jfx/pull/1055
