On Fri, 24 Feb 2023 00:24:56 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Review changes I looked at the code and it looks ok. Tests are fine. I added a comment about the warning message being printed in case 1. In general, I want to avoid scenario's where users keep asking questions about "What is this warning about GTK 2 library being ignored?" where they are given the answer "Oh, you can ignore that one." Too many problems occur from important warnings being ignored because they are covered in a pile of warnings that are never addressed. In general, I believe a warning should be considered as such. In case of case 1, there is an explicit request from a user, a script, another program... to use GTK 2. There is probably a reason for that explicit request, and that needs to be addressed by the maintainer of the script or similar. But that requires giving enough information to the user who is facing the warning. The case 2 and case 3 situations are very different, and they don't result in warnings that can easily be ignored (as they are fatal exceptions), so those are correct. I don't see my comments as a showstopper, so in case you don't want to address them (or in case other reviewers disagree with me), I'll go ahead and approve anyhow. ------------- PR: https://git.openjdk.org/jfx/pull/999
