On Fri, 24 Feb 2023 06:20:22 GMT, Karthik P K <k...@openjdk.org> wrote:

>> I would also recommend testing the code on Windows with the screen scale set 
>> to 225%, as it might show issues related to fractional scale.
>
>> I get the impression this code also needs to use `caretWidth / 2` instead of 
>> `0` and `1`.
>> 
> Here also same comment as above for the `newX < caretWidth/2` condition. But 
> while comparing the `oldX`, `caretWidth/2` should be considered instead of 1 
> and also `caretWidth / 2` is subtracted from `textRight` value in the 
> previous if condition as you suggested. These updates have been done in the 
> code.
> 
>> I would also recommend testing the code on Windows with the screen scale set 
>> to 225%, as it might show issues related to fractional scale.
> 
> I will test this latest code updates.

Tested in windows with screen scale set to as high as 225%. Couldn't reproduce 
any issues with updated code.

-------------

PR: https://git.openjdk.org/jfx/pull/980

Reply via email to