> When Text width was more than TextField width, the logic to update > `textTranslateX` in `updateCaretOff` method was causing the issue of > unexpected behavior for Right and Center alignment. > > Made changes to update `textTranslateX` in `updateCaretOff` method only when > text width is less than text field width i.e `delta` is positive. > For both right and center alignments, the `textTranslateX` value calculated > in `updateTextPos` method will be updated without any condition so that > expected behavior is achieved for all scenarios of text width relative to > text field width. > > Added unit tests to validate LEFT, CENTER and RIGHT alignments. RIGHT and > CENTER alignment tests are expected to fail without the fix provided in this > PR.
Karthik P K has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into textfield_issue_fix - Update comments - Fix textfield right and center alignment issues - Fix for TextField right alignement issue ------------- Changes: - all: https://git.openjdk.org/jfx/pull/980/files - new: https://git.openjdk.org/jfx/pull/980/files/8c1cd0c2..622cac30 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=980&range=03 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=980&range=02-03 Stats: 204507 lines in 6889 files changed: 121197 ins; 43586 del; 39724 mod Patch: https://git.openjdk.org/jfx/pull/980.diff Fetch: git fetch https://git.openjdk.org/jfx pull/980/head:pull/980 PR: https://git.openjdk.org/jfx/pull/980
