On Wed, 8 Feb 2023 07:42:14 GMT, Karthik P K <k...@openjdk.org> wrote:
>> While checking for duplicate series addition to the line chart, >> `setToRemove` value was not considered before throwing exception. Hence code >> to handling the case of adding the removed series was never run. >> >> Added condition to check `setToRemove` boolean value before throwing >> exception. Made changes to call `setChart` method after calling >> `seriesBeingRemovedIsAdded`. Otherwise chart will not be drawn for the >> series, only points will be plotted. >> >> This issue is reproducible only when animation is enabled because timeline >> will be still running when removed series is added back to the same chart. >> Since timeline does not run in unit tests, added system test to validate the >> fix. > > Karthik P K has updated the pull request incrementally with two additional > commits since the last revision: > > - Renamed system test file > - Fixing issue in all XYCharts Fixed duplicate child added exception in all XYCharts. In `StackedBarChart`, Y axis value was being manipulated with relative zero position. Due to this the actual Y value was getting changed and chart was getting modified as we remove and add the series back to the chart. Fixed this issue as well. Added system test to validate the fix for all the XYCharts. @aghaisas and @andy-goryachev-oracle please review these changes. ------------- PR: https://git.openjdk.org/jfx/pull/1015
