On Sat, 4 Feb 2023 15:27:13 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> JoachimSchriek has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Deleted trailing whitespace > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line 2611: > >> 2609: >> 2610: lengthBar.setMax(1); >> 2611: lengthBar.setVisibleAmount( numCellsVisibleOnScreen / >> (float) cellCount); > > I'm concerned with the change to no longer use the estimated size. This will > produce very different results for tables with variable row hights. @johanvos > will very likely want to comment on this. > > Also, The cast is unnecessary. > > Minor: remove the space after the `(` I am very sorry at this point. I have made a mistake here because my changes were based on the code I had seen in 2017 and reported in JDK-8173321. At that time, the size calculation of the ScrollBar was based on the integer value of numCellsVisibleOnScreen. I will revert the changes to VirtualFlow. ------------- PR: https://git.openjdk.org/jfx/pull/985
