On Sun, 22 Jan 2023 01:28:46 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge remote-tracking branch 'origjfx/master' into
>> JDK-8277848-list-binding-leak
>>
>> # Conflicts:
>> #
>> modules/javafx.base/src/main/java/javafx/beans/property/ListPropertyBase.java
>> #
>> modules/javafx.base/src/main/java/javafx/beans/property/SetPropertyBase.java
>> #
>> modules/javafx.base/src/test/java/test/javafx/beans/property/SetPropertyBaseTest.java
>> - Merge remote-tracking branch 'origjfx/master' into
>> JDK-8277848-list-binding-leak
>> - JDK-8277848
>> Added tests to ensure no premature garbage collection is happening.
>> - JDK-8277848
>> Added 3 more tests to verify that a bug discussed in the PR does not
>> appear.
>> - JDK-8277848
>> Added the 3 requests whitespaces
>> - JDK-8277848
>> Further optimization based code review.
>> This Bugfix should now event improve the performance
>> - JDK-8277848
>> Added missing change
>> - JDK-8277848
>> Fixed memoryleak, when binding and unbinding a ListProperty. The same was
>> fixed for SetProperty and MapProperty.
>
> modules/javafx.base/src/test/java/test/javafx/beans/property/ListPropertyBaseTest.java
> line 824:
>
>> 822: JMemoryBuddy.memoryTest(checker -> {
>> 823: // given
>> 824: System.out.println("Start collection: " +
>> FXCollections.observableArrayList());
>
> By the way, can these `println` statements in various tests be removed?
Done! I've removed the 3 print statements!
-------------
PR: https://git.openjdk.org/jfx/pull/689
